-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor checkpoint cleanup #3939
minor checkpoint cleanup #3939
Conversation
- remember list of checkpoints browser-side - cleanup references in MenuBar restore list. There was a closure issue, where multiple menu items would actually all restore the same checkpoint.
@rgbkrk, if you want to test this with your repo, I think it should be better behaved. |
Neat! I'll test against this commit. |
This is awesome! It's totally seamless and works flawlessly. Was able to restore to several different checkpoints while working with a notebook. It all worked as it should. |
👍 Is there some amount of testing or other work I could do to get this PR into 1.0? |
I think this has missed the cutoff for 1.0. I will make sure it's in the first 1.x bugfix release, though. |
Cool. I'll just have bookstore release with single checkpoint for now (multi is on GitHub, not on PyPI yet). |
Looks good to me, and seeing comment, merging. |
minor checkpoint cleanup remember list of checkpoints browser-side don't clobber list when a new checkpoint is created cleanup references in MenuBar restore list. There was a closure issue, where multiple menu items would actually all restore the same checkpoint.
- remember list of checkpoints browser-side - don't clobber list when a new checkpoint is created - cleanup references in MenuBar restore list. There was a closure issue, where multiple menu items would actually all restore the same checkpoint. Issues revealed by rgbkrk/bookstore, which supports multiple checkpoints. I'm fine if this doesn't get into 1.0, given timing.
minor checkpoint cleanup remember list of checkpoints browser-side don't clobber list when a new checkpoint is created cleanup references in MenuBar restore list. There was a closure issue, where multiple menu items would actually all restore the same checkpoint.
There was a closure issue, where multiple menu items would actually all
restore the same checkpoint.
Issues revealed by rgbkrk/bookstore, which supports multiple checkpoints.
I'm fine if this doesn't get into 1.0, given timing.